Add SfM Expanding application #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftechnicolor
force-pushed
the
dev/sfmExpanding
branch
from
a85d634
to
0f23520
Compare
servantftechnicolor
force-pushed
the
dev/sfmExpanding
branch
from
56fb14e
to
2800d71
Compare
cbentejac
reviewed
Jul 12, 2024
| { | ||
| Eigen::JacobiSVD<Mat3> USV(E, Eigen::ComputeFullU | Eigen::ComputeFullV); | ||
| Mat3 U = USV.matrixU(); | ||
| // Vec3 d = USV.singularValues(); |
| sfm::ExpansionProcess::uptr expansionProcess = std::make_unique<sfm::ExpansionProcess>(); | ||
| expansionProcess->setExpansionHistoryHandler(expansionHistory); | ||
| expansionProcess->setExpansionIterationHandler(expansionIteration); | ||
| /*expansionProcess->setExpansionIterationPostProcessHandler(expansionPostProcess);*/ |
Comment on lines
+197
to
+202
| /*sfm::ExpansionPostProcess::uptr expansionPostProcess; | ||
| if (useRigConstraint) | ||
| { | ||
| sfm::ExpansionPostProcessRig::uptr expansionPostProcessTyped = std::make_unique<sfm::ExpansionPostProcessRig>(); | ||
| expansionPostProcessTyped->setMinimalNumberCameras(minNbCamerasForRigCalibration); | ||
| expansionPostProcess = std::move(expansionPostProcessTyped); |
| @@ -385,8 +331,8 @@ int aliceVision_main(int argc, char** argv) | |||
| bestUsedTracks = usedTracks; | |||
| } | |||
| } | |||
|
|
|||
| if (!buildSfmData(sfmData, bestPair, mapTracks, bestUsedTracks)) | |||
|
|
|||
| @@ -0,0 +1,92 @@ | |||
| // This file is part of the AliceVision project. | |||
| // Copyright (c) 2023 AliceVision contributors. | |||
| @@ -0,0 +1,180 @@ | |||
| // This file is part of the AliceVision project. | |||
| // Copyright (c) 2023 AliceVision contributors. | |||
| @@ -0,0 +1,86 @@ | |||
| // This file is part of the AliceVision project. | |||
| // Copyright (c) 2023 AliceVision contributors. | |||
| @@ -0,0 +1,199 @@ | |||
| // This file is part of the AliceVision project. | |||
| // Copyright (c) 2023 AliceVision contributors. | |||
| @@ -0,0 +1,228 @@ | |||
| // This file is part of the AliceVision project. | |||
| // Copyright (c) 2023 AliceVision contributors. | |||
| @@ -0,0 +1,221 @@ | |||
| // This file is part of the AliceVision project. | |||
| // Copyright (c) 2023 AliceVision contributors. | |||
cbentejac
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New application for sfm expansion using an initial sfm solve (E.g. using sfmBootstrapping)
New objects for policies :
More modular approach to SFM to be able to change it's behavior more easily.
Extracted the various steps in different classes for better readability